Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target and change update handlers api #78

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Remove target and change update handlers api #78

merged 3 commits into from
Apr 22, 2020

Conversation

alex35mil
Copy link
Member

Fixes #68

@alex35mil alex35mil mentioned this pull request Apr 22, 2020
Closed
johnhaley81
johnhaley81 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@johnhaley81 johnhaley81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an API/code perspective, everything looks great to me! I wasn't able to pull the branch down and use the PPX since the actual lib is under the lib folder. I'll test this out in our app as soon as it's on NPM.

@alex35mil
Copy link
Member Author

@johnhaley81 Thanks! v4.0.0-beta.4 is published.

@alex35mil
Copy link
Member Author

Merging.

@alex35mil alex35mil merged commit e3f044a into master Apr 22, 2020
@alex35mil alex35mil deleted the update-handlers branch April 22, 2020 18:37
@johnhaley81
Copy link
Contributor

@alexfedoseev things look good! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhaley81 johnhaley81 johnhaley81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update handlers API
2 participants
@alex35mil @johnhaley81