Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing page title in documentation #2833

Closed
tbreuss opened this issue May 1, 2023 · 0 comments · Fixed by #2837
Closed

Missing page title in documentation #2833

tbreuss opened this issue May 1, 2023 · 0 comments · Fixed by #2837
Assignees
@dead-claudia
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@tbreuss
Copy link
Contributor

tbreuss commented May 1, 2023 •
edited
Loading

Since version 2.2.0 the correct page titles are missing in the documentation.
Each page is named "Mithril.js" which is bad for SEO reasons.
It could also lead to a worse position in search engine results, if not already happen.
The last working version was 2.0.4.

The regex here could be the cause:
https://github.com/MithrilJS/mithril.js/blob/next/scripts/generate-docs.js#L164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dead-claudia dead-claudia

Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
2 participants
@tbreuss @dead-claudia