Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore running validation on feeds with unknown_column notices #1770

Closed
emmambd opened this issue May 27, 2024 · 3 comments
Closed

Explore running validation on feeds with unknown_column notices #1770

emmambd opened this issue May 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature request or improvement on an existing feature

Comments

@emmambd
Copy link
Contributor

emmambd commented May 27, 2024

Describe the problem

Investigation in #1767 showed that Flex feeds are not being parsed because they have the unknown_column notice. We want to be confident that this is the reason why Flex feeds are having parsing issues.

Proposed solution

  • Run analysis to see how many feeds in the acceptance tests have the unknown column notice (can use the Raw Data from the last analysis)

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels May 27, 2024
@jcpitre
Copy link
Contributor

jcpitre commented May 27, 2024

Tasks:

  • Investigate why unknown column leads to unparsable
  • Test by adding a column to a feed without errors and see what happens

@emmambd emmambd removed the status: Needs triage Applied to all new issues label May 27, 2024
@jcpitre jcpitre assigned jcpitre, davidgamez and qcdyx and unassigned jcpitre May 27, 2024
@qcdyx
Copy link
Contributor

qcdyx commented May 29, 2024

  1. It's the missing_required_field 'stop_id' that leads to a validation error, which makes stop_times.txt have a status of UNPARSABLE_ROWS.
  2. added a 'UNKNOWN_COLUMN' to stop_times.txt of browncounty-mn-us--flex-v2 dataset, run GTFS validator, no UNPARSABLE_ROWS for stop_times.txt.

@emmambd
Copy link
Contributor Author

emmambd commented May 29, 2024

Closing this issue as a duplicate of #1767

@emmambd emmambd closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants