Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for checks, improved implementation for ranger random survival forest #29

Merged
merged 26 commits into from
Sep 27, 2023
Merged

Conversation

krzyzinskim
Copy link
Collaborator

@krzyzinskim krzyzinskim commented Sep 26, 2023

PR aimed at preparing a new version for CRAN release.

Changes:

  • automated website building added for workflows
  • updated website in /docs (to be deleted after successful automatic website generation on a separate branch)
  • changes to DESCRIPTION -- updated list of authors
  • fixes in examples and tests
  • improved implementation for ranger random survival forest -- added support for cumulative hazard function predictions, speeding up implementation

@krzyzinskim krzyzinskim changed the title Fix tests, examples and checks Fixes for checks, improved implementation for ranger random survival forest Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #29 (f14a490) into master (8ee465f) will increase coverage by 1.61%.
Report is 7 commits behind head on master.
The diff coverage is 92.85%.

❗ Current head f14a490 differs from pull request most recent head b31ce32. Consider uploading reports for the commit b31ce32 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   68.13%   69.74%   +1.61%     
==========================================
  Files          18       19       +1     
  Lines         819      876      +57     
==========================================
+ Hits          558      611      +53     
- Misses        261      265       +4     
Files Coverage Δ
R/treeshap.R 83.33% <ø> (ø)
R/unify_catboost.R 89.33% <100.00%> (ø)
R/unify_gbm.R 97.29% <100.00%> (ø)
R/unify_lightgbm.R 94.00% <ø> (ø)
R/unify_ranger.R 96.77% <100.00%> (+0.34%) ⬆️
R/unify_randomForest.R 94.11% <0.00%> (ø)
R/unify_ranger_surv.R 92.59% <92.59%> (ø)

Copy link
Collaborator

@mikolajsp mikolajsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mikolajsp mikolajsp merged commit 9709a50 into ModelOriented:master Sep 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants