Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail QA: Bullet points #1331

Closed
alanmoo opened this issue Apr 12, 2018 · 1 comment
Closed

Wagtail QA: Bullet points #1331

alanmoo opened this issue Apr 12, 2018 · 1 comment
Assignees
Labels
wagtail wagtail related issues

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Apr 12, 2018

From @kristinashu in #1325

  • Spacing after bullet points should be the same or larger than before them
    Screen cap from production looks confusing because bullets look grouped with content bellow, not above

image

@alanmoo alanmoo added the wagtail wagtail related issues label Apr 12, 2018
@Pomax Pomax self-assigned this Apr 12, 2018
@Pomax
Copy link
Contributor

Pomax commented Apr 12, 2018

The reason this is going wrong is because the structure her is:

<p> Bylaws [...]</p>
<ul>
   [ list elements]
</ul>
<p>Conflict [...] </p>

and paragraphs have uneven margins. Our CSS sets this:

p {
  margin-top: 0;
  margin-bottom: 1rem; }

and so the real problem is the paragraph below the ul "glueing" itself to the content above it.

This rule seems to come from bootstrap-reboot.css so we might be missing our own override here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wagtail wagtail related issues
Projects
None yet
Development

No branches or pull requests

2 participants