-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: add share buttons #3157
Comments
Do we plan to turn these button styles into two new "button group" styles or these are more one-off things? |
We're exploring that question more here MozillaFoundation/Design#339 but I can see use using these buttons elsewhere (for example on our campaign pages). |
kk I'll treat them as custom style for now until we've decided to move them to the official style guide. @kristinashu how should each button function? I assume similar to what we have on PNI? If so do we have default text to share out? |
Yes same functionality please. Copy can just be:
|
@kristinashu should we make sure these icons are from set Sabrina designed? I know Twitter icon on Foundation site has been updated but the other three icons still need to be replaced. If you think this is a good idea can you include link to the icon folder? I can generate white icon version myself by editing the source code of the icon SVG. |
Let's for sure use them! @beccaklam is looking at this right now in the button audit. Becca, do you think the new icons at max 16px will work here too? |
Sorry for the late reply on this, I was testing out the icons yesterday but got sidetracked by other work. I actually think 24px will work better for the circular buttons, as the 16px looks too small. As for the PNI share buttons, I don't feel a need to change them. I see PNI as more of a unique instance/microsite than an extension of the Foundation site. But others feel free to weigh in. |
Yes, I'll get you these icons @mmmavis! |
So, fidgeted with the icons again and 16px does work after all ... Here are the icons @mmmavis: |
Ah, hold off on the facebook icon @mmmavis, I need to get you the official one instead. Will update my tomorrow morning! |
@beccaklam No rush! I have to shift my focus to get the join us modal on Pulse to work first. 😉 |
Blocked on PR #3352 (Added 'share button group' style + example on /styleguide) |
Build on the Blog MVP work to fully flesh out capabilities.
Requirements Checklist:
Desktop (with hover states):
Tablet & Mobile: see https://redpen.io/p/bha12cf7387de4f7e7 (note that there are no side share buttons)
The text was updated successfully, but these errors were encountered: