Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: add share buttons #3157

Closed
7 of 9 tasks
kristinashu opened this issue May 14, 2019 · 13 comments · Fixed by #3383
Closed
7 of 9 tasks

Blog: add share buttons #3157

kristinashu opened this issue May 14, 2019 · 13 comments · Fixed by #3383
Assignees
Labels
frontend wagtail wagtail related issues
Milestone

Comments

@kristinashu
Copy link

kristinashu commented May 14, 2019

Build on the Blog MVP work to fully flesh out capabilities.

Requirements Checklist:

  • Sticky Side Share buttons (disappears on mobile)
  • Share buttons at the bottom of the blog post

Desktop (with hover states):

Post-MVP-hover-states@2x

Tablet & Mobile: see https://redpen.io/p/bha12cf7387de4f7e7 (note that there are no side share buttons)

@kristinashu kristinashu added wagtail wagtail related issues frontend labels May 14, 2019
@beccaklam beccaklam mentioned this issue May 14, 2019
7 tasks
@mmmavis
Copy link
Collaborator

mmmavis commented May 14, 2019

Do we plan to turn these button styles into two new "button group" styles or these are more one-off things?

@kristinashu
Copy link
Author

We're exploring that question more here MozillaFoundation/Design#339 but I can see use using these buttons elsewhere (for example on our campaign pages).

@mmmavis mmmavis self-assigned this May 15, 2019
@mmmavis
Copy link
Collaborator

mmmavis commented May 15, 2019

We're exploring that question more here MozillaFoundation/Design#339 but I can see use using these buttons elsewhere (for example on our campaign pages).

kk I'll treat them as custom style for now until we've decided to move them to the official style guide.

@kristinashu how should each button function? I assume similar to what we have on PNI?

image

If so do we have default text to share out?

@kristinashu
Copy link
Author

Yes same functionality please. Copy can just be:

[Title of blog post] by @mozilla [url to blog post]

@kristinashu kristinashu mentioned this issue May 16, 2019
25 tasks
@mmmavis
Copy link
Collaborator

mmmavis commented Jun 4, 2019

@kristinashu should we make sure these icons are from set Sabrina designed? I know Twitter icon on Foundation site has been updated but the other three icons still need to be replaced. If you think this is a good idea can you include link to the icon folder? I can generate white icon version myself by editing the source code of the icon SVG.

@kristinashu
Copy link
Author

Let's for sure use them! @beccaklam is looking at this right now in the button audit. Becca, do you think the new icons at max 16px will work here too?

@mmmavis
Copy link
Collaborator

mmmavis commented Jun 5, 2019

While we are on this... do we plan to update the pill buttons on PNI to the rectangular ones we are adding to the blog page?

image

This was referenced Jun 5, 2019
@beccaklam
Copy link

Sorry for the late reply on this, I was testing out the icons yesterday but got sidetracked by other work. I actually think 24px will work better for the circular buttons, as the 16px looks too small. As for the PNI share buttons, I don't feel a need to change them. I see PNI as more of a unique instance/microsite than an extension of the Foundation site. But others feel free to weigh in.

@beccaklam
Copy link

@kristinashu should we make sure these icons are from set Sabrina designed? I know Twitter icon on Foundation site has been updated but the other three icons still need to be replaced. If you think this is a good idea can you include link to the icon folder? I can generate white icon version myself by editing the source code of the icon SVG.

Yes, I'll get you these icons @mmmavis!

@beccaklam
Copy link

beccaklam commented Jun 6, 2019

So, fidgeted with the icons again and 16px does work after all ... Here are the icons @mmmavis:
share-buttons.zip. I also updated the redpen with the new icons.

@beccaklam
Copy link

Ah, hold off on the facebook icon @mmmavis, I need to get you the official one instead. Will update my tomorrow morning!

@mmmavis
Copy link
Collaborator

mmmavis commented Jun 6, 2019

@beccaklam No rush! I have to shift my focus to get the join us modal on Pulse to work first. 😉

@mmmavis
Copy link
Collaborator

mmmavis commented Jun 26, 2019

Blocked on PR #3352 (Added 'share button group' style + example on /styleguide)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment