Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade in/out effect for sticky share buttons on blog page #3425

Closed
mmmavis opened this issue Jul 16, 2019 · 5 comments · Fixed by #3429
Closed

Fade in/out effect for sticky share buttons on blog page #3425

mmmavis opened this issue Jul 16, 2019 · 5 comments · Fixed by #3429

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Jul 16, 2019

Follow-up from PR #3383

Currently we hide sticky buttons on the side when the bottom share buttons are scrolled into the viewport.

From Pomax's comment in the PR

do we want to make the buttons fade out/in rather than abruptly existing, though? It might be jarring to readers to have them suddenly exist or be gone?

@beccaklam thoughts?

@mmmavis
Copy link
Collaborator Author

mmmavis commented Jul 16, 2019

/cc @Pomax

@beccaklam
Copy link

@Pomax @mmmavis I can't see staging anymore but fade in/out sounds good 👍 Thanks for catching that Pomax.

@mmmavis
Copy link
Collaborator Author

mmmavis commented Jul 17, 2019

hey @beccaklam by "staging" you mean "review app"? Review app is the app that's generated with every PR and self destruct when the PR gets merged 😉

Changes have been pushed to staging (https://foundation.mofostaging.net). Blog example on staging can be found here

@beccaklam
Copy link

@mmmavis Oh I see ... thanks :) Just checked it out. I think fading in/out would be a nice transition effect!

@alanmoo alanmoo added this to the Aug 5 milestone Jul 17, 2019
@mmmavis mmmavis self-assigned this Jul 17, 2019
@mmmavis
Copy link
Collaborator Author

mmmavis commented Jul 17, 2019

I'm gonna move this ticket to this sprint 'cuz I've got a PR up for this already 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants