Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow longer strings for homepage hero button #3646

Closed
TheoChevalier opened this issue Sep 13, 2019 · 3 comments
Closed

Allow longer strings for homepage hero button #3646

TheoChevalier opened this issue Sep 13, 2019 · 3 comments
Assignees
Milestone

Comments

@TheoChevalier
Copy link
Contributor

As you can tell from the screenshot, the Portuguese translation needed a few more characters. I expect this issue to happen again, so we should find a way to allow for longer translations.

Screenshot_2019-09-13 Wagtail - Editing Homepage Homepage

I’m assuming the limit was set to avoid breaking the layout on mobile, but it may be possible to allow buttons to wrap in multiple lines?

FTR, the 50 characters limit is set here https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/factory/homepage.py#L33

@cadecairos
Copy link

@TheoChevalier is it a fair ask that instead of a 1:1 translation, we get a localized string? A button with that much text in it looks pretty crowded.

@cadecairos cadecairos added this to the Icebox milestone Feb 25, 2020
@kristinashu
Copy link

Agree, I don't think button text should be that long (including the English version). @TheoChevalier are you ok to keep this as is but push for shorter button text in general i.e. just "Share your story"

@TheoChevalier
Copy link
Contributor Author

Agree, I don't think button text should be that long (including the English version). @TheoChevalier are you ok to keep this as is but push for shorter button text in general i.e. just "Share your story"

I think we can do this, yep. If we keep hitting this issue, we can think about making this requirement more prominent, for instance by editing the helptext next to the field.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants