Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid event severity detection for weatheralerts #145

Closed
MrBartusek opened this issue Jan 14, 2023 · 0 comments · Fixed by #175
Closed

Invalid event severity detection for weatheralerts #145

MrBartusek opened this issue Jan 14, 2023 · 0 comments · Fixed by #175
Labels
bug Something isn't working integration: weatheralerts

Comments

@MrBartusek
Copy link
Owner

The current implementation of weatheralerts integration relies on severity attribute rather than detecting if the alert is a warning, advisory, watch or statement this can produce invalid alert severity (#144 - severity: Extreme, Tornado Watch). This integration should rely on detecting last word of alert like env_canada:

https://github.com/MrBartusek/MeteoalarmCard/blob/master/src/integrations/env_canada.ts#L244-L255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration: weatheralerts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant