Update to bevy 0.8 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, thanks for the contribution! I'll take a look at this tonight. |
MrGVSV
requested changes
Sep 21, 2022
examples/atlas.rs
Outdated
| .add_system_set(SystemSet::on_enter(AppState::LoadTileset).with_system(load_tiles)) | ||
| .add_system_set(SystemSet::on_update(AppState::LoadTileset).with_system(load_tiles)) |
There was a problem hiding this comment.
Rather than changing this, can you instead change this line from set to overwrite_set?https://github.com/MrGVSV/bevy_tile_atlas/blob/main/examples/atlas.rs#L57-L57
The result is pretty much the same either way, but loading the tileset on enter feels more idiomatic.
MrGVSV
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MrGVSV I hope you don't mind me updating this library to work with bevy 0.8
Except for updating dependencies.
Because of this change in bevy_asset crate, there was one small update that needed to be made to library code.
I have needed to do some changes to example.