Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

wrong comparison between seconds and milliseconds #253

Open
ashayk opened this issue Dec 4, 2015 · 3 comments
Open

wrong comparison between seconds and milliseconds #253

ashayk opened this issue Dec 4, 2015 · 3 comments

Comments

@ashayk
Copy link

ashayk commented Dec 4, 2015

line 418:
if ([[NSDate date] timeIntervalSince1970] > [expiresDateMs doubleValue])

should read:
if ([[NSDate date] timeIntervalSince1970] > [expiresDateMs doubleValue]/1000.)

@ethanwa
Copy link

ethanwa commented May 9, 2016

I can confirm that this is a bug that needs to be fixed.

@hankinsoft
Copy link

This looks like its been fixed in the current code stream. The issue can probably be closed.

@cujo30227
Copy link

nope it is note. Line 170 is fixed, line 418 is not...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants