Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Error in gas price value, could lead to funds loss because of extremely high gas price #2133

Closed
un1t opened this issue Oct 31, 2018 · 4 comments

Comments

@un1t
Copy link

un1t commented Oct 31, 2018

How to reproduce:

Go to "Send Offline" page
Switch gas price unit to "gwei".
Enter from address and push "Generate Information" button
Check gas price value. I my case it should be 4 gwei, but instead it is 4000000000 gwei.
After gas price unit is switched to gwei you can refresh page, enter address and push "Generate Information" button, price again will be 4000000000 gwei.

Expected behaviour - gas price should be billion times less in gwei.

My environment - Chrome, Ubuntu 16.04

@kvhnuke
Copy link
Collaborator

kvhnuke commented Oct 31, 2018

@gamalielhere please reset the drop-down back to Wei when generate information button pressed, or detect which unit it is in and calculate the correct value

@un1t thank you for bringing this to our attention

@un1t
Copy link
Author

un1t commented Oct 31, 2018

please reset the drop-down back to Wei when generate information button pressed

I don't like price in wei, there are too many zeros. Very easy to make mistakes.

or detect which unit it is in and calculate the correct value

I think, this is right behaviour

@gamalielhere
Copy link
Collaborator

@un1t @kvhnuke I sent up a fix on #2134 . Let me know what you guys think

@gamalielhere
Copy link
Collaborator

Closing this. Please feel free to open if it's still an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants