-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add feed_contact_email field to system_information.json #181
Conversation
+1 for optional See issues #149, #177, #178, and #179 for examples of data quality issues being reported on this repo.
IMHO I would say no. It should, however, be a best practice to include the field.
I don't think that's necessary - the current description makes it's purpose pretty clear - "A single contact email address for customers to address questions about the system" |
@barbeau Thoughts on using |
+1 for aligning the name with GTFS. I think there's a case to be made for this being a required field but that could come later as part of a major release. In the interim it could be added as an optional field. |
Using |
Updated. |
+1 Thanks for adding this field. Just a thought: Should this be an array of emails to be more flexible? I don't lean either way. A group alias can always be defined instead. |
To stay consistent with GTFS and with the existing |
Seems like we have consensus here, what are the next steps for including this in the upcoming version of GBFS? |
As an optional field, it seems like this would be ready for the formal approval step with a merge into master, with inclusion into the next minor release. |
Hi @contra: Thanks for pinging on this. Please go ahead and call the vote! Here's an example "call the vote" comment: #188 (comment). |
I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Thursday, Nov 28. Please vote for or against the proposal to add the feed_contact_email field, and include the organization for which you are voting in your comment. |
👍 from me as an independent developer |
👍 from me from OneBusAway/USF Prior to merging this, though, do we need a producer and consumer of the field? |
+1 from me from Google Maps |
+1 from Transit |
👍 from me as an independent mobility enthusiast |
@barbeau We do need a producer to vote on this. And as part of the governance pilot, we're going to work on language about implementor commitment happening in parallel with vote. |
I don't think consumer have anything to "implement" here, more than just using the field internally when appropriate. Nothing to change in the consumer application. |
+1 from IBI Group |
Sorry, folks, to have to do this, but we're going to re-open the vote. Since it closed on a holiday in the US, and we still need a producer to chime in, we're giving it another go and keeping it open an extra day. I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Monday, December 9th. Please vote for or against the proposal to add the feed_contact_email field, and include the organization for which you are voting in your comment. |
+1 from PBSC |
@MuteQ @evansiroky @kanagy Would you all mind voting again now that we had to re-open the vote? Thank you! |
+1 from Transit |
+1 from IBI Group |
+1 from Lime |
+1 Ride Report |
+1 Google Maps |
+1 JUMP |
+1 Bird |
The vote has passed! 4 votes in favor from producers:
4 votes in favor from consumers:
|
Are there any GBFS feeds that are supplying this field? I have gone ahead and merged this, expecting GBFS feeds to provide this field soon. I expect we'll need to be more rigorous about waiting for producer/consumer implementations before a release in the future, but right now GBFS in catch up mode. |
We'd love to make this an official part of the spec, but first we need to see this change being implemented. Could you comment here if your organization has implemented this? |
We at IBI Group may not imminently implement code to ingest this, but will definitely manually inspect feeds for this data if we need to. |
Issue
Currently as a consumer of a feed, you have no real way to contact the operator of that feed. The
email
attribute is meant for general support purposes, so doesn't solve this issue. This results in issues being opened on this repository and causes a really painful feedback loop of trying to locate the person who can fix the actual problem. This is particularly relevant as we've been discussing more systematic validation tools for feeds in systems.csv in the GBFS workshop.Solution
Non-breaking, adds an optional
technical_email
property tosystem_information.json
where providers can specify where to send bug/validation/etc. reports.Feedback needed
email
be renamed tosupport_email
to clarify it's purpose?