-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify num_bikes_available and num_docks_available definitions #195
Conversation
Addressing issue #94
@heidiguenin I would say this is backwards or unnecessary. If a station contains X bikes and is_renting is false (0) then num_bikes_available would be zero and num_bikes_disabled would be X. Same would apply to docks if is_returning were false |
@mplsmitch Did you have the chance to look through the conversation over at #94 again? This is the solution that was agreed upon after quite a bit of back and forth. |
@heidiguenin you're correct- disregard my previous comment |
While you're here, can you change num_docks_available to be optional? That would allow better handling of virtual stations. Comment could say: Required, except for stations that have unlimited docking capacity (e.g. virtual stations). I found at least one feed that does not set num_docks_available because of this. |
Updated based on @kanagy's comment. |
@kanagy Thinking on this more, shouldn't num_docks_available then be Conditionally required? Am I understanding your use cases correctly? |
+1 from PBSC |
Changed to conditionally required to reflect feedback about virtual stations
I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on December 11th. Please vote for or against the proposal, and include the organization for which you are voting in your comment. |
@maduprasPBSC @kanagy I have updated the proposal and opened the vote. Let me know if that works for you! |
Still works for us. Thanks for the update |
+1 from IBI Group |
+1 from Google Maps. We've noticed that some systems with virtual stations already treat num_docks_available as optional. |
Yes, sorry for the late reply. Thanks for updating. |
+1 from Transit |
+1 JUMP |
|
Voting has closed and this changed has been passed. Six votes were in favor: PBSC (Vendor / GBFS producer) There were no votes against or neutral votes. @MobilityData is refining how we'll implement the versioning scheme (#188). We'll merge this once we arrive at a sensible release process (see #163). |
Just for clarification @mdwestervelt, was that a vote for or against from Bird? (I see that you had typed "-1 Bird" and I wasn't sure if that was a negative vote or if that was intended to be markdown formatting). |
Sorry! Was briefly working on an international keyboard. +1
…On Tue, Dec 10, 2019 at 6:13 PM Jesse Chan-Norris ***@***.***> wrote:
Just for clarification @mdwestervelt <https://github.com/mdwestervelt>,
was that a vote for or against from Bird? (I see that you had typed "-1
Bird" and I wasn't sure if that was a negative vote or if that was intended
to be markdown formatting).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALAJZ5LCS6EZ7JWQ23PHIFLQX7E5BANCNFSM4JQVHOFA>
.
--
Marla Westervelt
*B I R D*
|
add back in the description that was removed
Eliminate new spaces that were showing up in the diff
Addressing issue #94.
I've updated the language for num_bikes_available and num_docks_available. Does this create enough clarity?