Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Inconsistency in names #34

Open
wachsylon opened this issue Mar 1, 2022 · 2 comments
Open

Inconsistency in names #34

wachsylon opened this issue Mar 1, 2022 · 2 comments

Comments

@wachsylon
Copy link

Hi,

the aggregations object has a key attribute_name. I suggest to change that to column_name since in all other cases column_name is used (e.g. variable_column_name, format_column_name).

Best,
Fabi

@wachsylon
Copy link
Author

....aaaandd there is also groupby_attrs which of course could be groupby_column_names. But I start to think that it could also be a solution to do it the other way around?

@wachsylon
Copy link
Author

and what about options of the aggregation_object: If that is just xarray kwargs, why not naming it xarray_kwargs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant