Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin xarray from v2023.02.0 #98

Closed
hCraker opened this issue Mar 24, 2023 · 4 comments · Fixed by #159
Closed

Unpin xarray from v2023.02.0 #98

hCraker opened this issue Mar 24, 2023 · 4 comments · Fixed by #159
Assignees
@kafitzgerald
Labels
bug Something isn't working
Milestone
Continuous Integr...

Comments

@hCraker
Copy link
Contributor

hCraker commented Mar 24, 2023

Checks are failing due to a change in the latest version of xarray. Pinning xarray will solve the issue temporarily so we can release new changes to geocat-viz, but we will need to address the underlying cause at a later date.
@hCraker hCraker added the bug Something isn't working label Mar 24, 2023
@hCraker
Copy link
Contributor Author

hCraker commented Mar 24, 2023

Xarray has been pinned in PR #97. This issue will remain opened until it is unpinned

@hCraker hCraker changed the title Checks failing with the xarray v2023.03.0 Unpin xarray from v2023.02.0 Mar 28, 2023
@kafitzgerald
Copy link
Collaborator

Noting that this is because of an issue in geocat-comp where it used internal API from xarray that recently changed: NCAR/geocat-comp#381

@kafitzgerald
Copy link
Collaborator

Once xarray is (fully) pinned for comp in this upcoming release we should be able to remove our version pin here and just take care of things in comp instead of tracking elsewhere as well.

@kafitzgerald kafitzgerald self-assigned this Sep 8, 2023
@erogluorhan erogluorhan added this to the Continuous integration milestone Sep 19, 2023
@kafitzgerald kafitzgerald added blocked Work got blocked waiting the output of some other source/work and removed blocked Work got blocked waiting the output of some other source/work labels Sep 21, 2023
@kafitzgerald
Copy link
Collaborator

Blocked by: conda-forge/geocat-comp-feedstock#31

@anissa111 anissa111 removed the blocked Work got blocked waiting the output of some other source/work label Sep 22, 2023
@kafitzgerald kafitzgerald mentioned this issue Sep 22, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kafitzgerald kafitzgerald

Labels
bug Something isn't working
Projects
None yet
Milestone
Continuous Integration
Development

Successfully merging a pull request may close this issue.

Remove unnecessary Xarray version pin kafitzgerald/geocat-viz
5 participants
@kafitzgerald @pilotchute @erogluorhan @anissa111 @hCraker