fix(module:select): fix space closing select panel (#2240)

close #2201
NG-ZORRO · Oct 11, 2018 · 3d7fe39 · 3d7fe39
1 parent ebf151a
commit 3d7fe39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/components/select/nz-select.component.ts b/components/select/nz-select.component.ts
@@ -271,7 +271,8 @@ export class NzSelectComponent implements ControlValueAccessor, OnInit, AfterVie
         event.preventDefault();
       }
     } else {
-      if (keyCode === SPACE || keyCode === TAB) {
+      if (keyCode === TAB) {
+      // if (keyCode === SPACE || keyCode === TAB) { // #2201
         this.nzOpen = false;
         this.nzOpenChange.emit(this.nzOpen);
         event.preventDefault();

diff --git a/components/select/nz-select.spec.ts b/components/select/nz-select.spec.ts
@@ -212,7 +212,8 @@ describe('nz-select component', () => {
       flush();
       fixture.detectChanges();
       expect(testComponent.open).toBe(true);
-      dispatchKeyboardEvent(select.nativeElement.querySelector('.ant-select-selection'), 'keydown', SPACE);
+      // #2201, space should not close select panel
+      dispatchKeyboardEvent(select.nativeElement.querySelector('.ant-select-selection'), 'keydown', TAB);
       fixture.detectChanges();
       flush();
       fixture.detectChanges();