From 54ff18981f308f50e5bfb5b769e9ae89c3b2d902 Mon Sep 17 00:00:00 2001
From: Wilson Zeng <jackzcs@gmail.com>
Date: Sun, 10 Dec 2017 12:35:19 +0800
Subject: [PATCH] feat(module:tooltip,popover,popconfirm): do not show tooltip
 when it's content is empty

close #631
---
 src/components/tooltip/nz-tooltip.component.ts |  9 ++++++++-
 src/components/tooltip/nz-tooltip.directive.ts | 17 +++++++----------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/src/components/tooltip/nz-tooltip.component.ts b/src/components/tooltip/nz-tooltip.component.ts
index aa3bb32014b..210a04fcf04 100644
--- a/src/components/tooltip/nz-tooltip.component.ts
+++ b/src/components/tooltip/nz-tooltip.component.ts
@@ -137,7 +137,9 @@ export class NzToolTipComponent {
   }
 
   show(): void {
-    this.nzVisible = true;
+    if (!this.isContentEmpty()) {
+      this.nzVisible = true;
+    }
   }
 
   hide(): void {
@@ -165,4 +167,9 @@ export class NzToolTipComponent {
   }
 
   constructor(private _cdr: ChangeDetectorRef) { }
+
+  private isContentEmpty(): boolean {
+    // return this.nzTemplate ? !(this.nzTemplate.elementRef.nativeElement as HTMLElement).hasChildNodes() : this.nzTitle === '';
+    return this.nzTemplate ? false : (this.nzTitle === '' || this.nzTitle == null); // Pity, can't detect whether nzTemplate is empty due to can't get it's content before shown up
+  }
 }
diff --git a/src/components/tooltip/nz-tooltip.directive.ts b/src/components/tooltip/nz-tooltip.directive.ts
index c21729f7508..423b4d98d5b 100644
--- a/src/components/tooltip/nz-tooltip.directive.ts
+++ b/src/components/tooltip/nz-tooltip.directive.ts
@@ -19,16 +19,13 @@ export class NzTooltipDirective implements AfterViewInit {
   // [NOTE] Here hard coded, and nzTitle used only under NzTooltipDirective currently.
   // The inherited class such as NzPopconfirmDirective should override this property if want using this property.
   @Input('nz-tooltip')
+  get nzTitle(): string { return this.tooltip.nzTitle; }
   set nzTitle(title: string) {
     if (this.isDynamicTooltip) {
       this.tooltip.nzTitle = title;
     }
   }
 
-  get nzTitle(): string {
-    return this.tooltip.nzTitle;
-  }
-
   @HostBinding('class.ant-tooltip-open') isTooltipOpen;
 
   private tooltip: NzToolTipComponent;
@@ -41,15 +38,15 @@ export class NzTooltipDirective implements AfterViewInit {
       private resolver: ComponentFactoryResolver,
       private renderer: Renderer2,
       @Optional() tooltip: NzToolTipComponent) {
-    let normalizedTooltip: NzToolTipComponent = tooltip;
+
+    this.tooltip = tooltip;
     // Support faster tooltip mode: <a nz-tooltip="xxx"></a>. [NOTE] Used only under NzTooltipDirective currently.
-    if (!normalizedTooltip) {
+    if (!this.tooltip) {
       const factory = this.resolver.resolveComponentFactory(NzToolTipComponent);
-      normalizedTooltip = this.hostView.createComponent(factory).instance;
+      this.tooltip = this.hostView.createComponent(factory).instance;
       this.isDynamicTooltip = true;
     }
-    normalizedTooltip.setOverlayOrigin(this);
-    this.tooltip = normalizedTooltip;
+    this.tooltip.setOverlayOrigin(this);
   }
 
   ngAfterViewInit(): void {
@@ -58,7 +55,7 @@ export class NzTooltipDirective implements AfterViewInit {
       this.renderer.listen(this.elementRef.nativeElement, 'mouseenter', () => this.showSmoothly());
       this.renderer.listen(this.elementRef.nativeElement, 'mouseleave', () => {
         this.hideSmoothly();
-        if (!overlayElement) { // NOTE: we bind events under "mouseleave" due to the overlayRef is only created after the overlay was completely shown up
+        if (this.tooltip.overlay.overlayRef && !overlayElement) { // NOTE: we bind events under "mouseleave" due to the overlayRef is only created after the overlay was completely shown up
           overlayElement = this.tooltip.overlay.overlayRef.overlayElement;
           this.renderer.listen(overlayElement, 'mouseenter', () => this.showSmoothly());
           this.renderer.listen(overlayElement, 'mouseleave', () => this.hideSmoothly());