Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:upload): add upload component #1040

Merged
merged 8 commits into from
Mar 13, 2018
Merged

feat(module:upload): add upload component #1040

merged 8 commits into from
Mar 13, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Feb 8, 2018

无法编译通过,已知错误 #9550

Worked for me, tnx to all!
npm install copy-webpack-plugin@4.3.0 --save
p.s. I had to put --save to add to package/json
Fwi, is this temp solution, or?

@coveralls
Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage decreased (-0.2%) to 98.024% when pulling a0ca92a on cipchk:upload into bd3b710 on NG-ZORRO:0.7.0.

@vthinkxie
Copy link
Member

I just remove --prod to pass the ci

@vthinkxie vthinkxie added this to the 0.7.0 milestone Feb 22, 2018
@cipchk cipchk changed the title wip(module:upload): add upload component feat(module:upload): add upload component Mar 3, 2018
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #1040 into 0.7.0 will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.7.0    #1040      +/-   ##
==========================================
+ Coverage   97.75%   97.88%   +0.13%     
==========================================
  Files         146      149       +3     
  Lines        4847     5159     +312     
  Branches      575      620      +45     
==========================================
+ Hits         4738     5050     +312     
  Partials      109      109
Impacted Files Coverage Δ
components/upload/nz-upload-btn.component.ts 100% <100%> (ø)
components/upload/nz-upload-list.component.ts 100% <100%> (ø)
components/upload/nz-upload.component.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345b6c6...0d0e590. Read the comment docs.

@vthinkxie vthinkxie merged commit a9efbaa into NG-ZORRO:0.7.0 Mar 13, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* wip(module:upload): add upload component
- increase test coverage

* fix tslint
add modal in demo

* fix demo

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants