Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:message,notification): fix message/notification cause mult… #1218

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

wilsoncook
Copy link
Member

…i-detection error while used in dynamic creating component

close #391

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #391

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #1218 into master will increase coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
+ Coverage   97.17%   97.18%   +<.01%     
==========================================
  Files         185      185              
  Lines        7694     7705      +11     
  Branches     1014     1015       +1     
==========================================
+ Hits         7477     7488      +11     
  Misses         25       25              
  Partials      192      192
Impacted Files Coverage Δ
components/notification/nz-notification.service.ts 100% <100%> (ø) ⬆️
components/message/nz-message.service.ts 97.87% <93.75%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903d27a...5cd0232. Read the comment docs.

…i-detection error while used in dynamic creating component

close NG-ZORRO#391
@wilsoncook wilsoncook force-pushed the fix_message_detection_error branch from 07d5d8f to 5cd0232 Compare March 26, 2018 04:42
@wilsoncook wilsoncook merged commit f2624cb into NG-ZORRO:master Mar 26, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…i-detection error while used in dynamic creating component (NG-ZORRO#1218)

close NG-ZORRO#391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification error
1 participant