Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:autocomplete): form related bugs #1451

Merged
merged 1 commit into from
May 17, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1437

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #1451 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
+ Coverage   96.91%   96.92%   +0.01%     
==========================================
  Files         222      222              
  Lines        9488     9493       +5     
  Branches     1293     1294       +1     
==========================================
+ Hits         9195     9201       +6     
+ Misses         43       42       -1     
  Partials      250      250
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 96.64% <100%> (+0.11%) ⬆️
components/table/nz-table.component.ts 95.48% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ac404...db075f8. Read the comment docs.

style(module:autocomplete): fix test lint

test(module:autocomplete): add test

clean
@hsuanxyz hsuanxyz force-pushed the autocomplete/fix-form branch from 76e41c0 to db075f8 Compare May 16, 2018 07:30
@vthinkxie vthinkxie merged commit c91a0f8 into NG-ZORRO:master May 17, 2018
@hsuanxyz hsuanxyz deleted the autocomplete/fix-form branch July 1, 2018 07:01
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
style(module:autocomplete): fix test lint

test(module:autocomplete): add test

clean
close NG-ZORRO#1437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants