Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): close modal itself before destructing by the angul… #1769

Merged

Conversation

wilsoncook
Copy link
Member

…ar's lifecycle

close #1663

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1663

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wilsoncook wilsoncook changed the title fix(module:modal): close modal itself before destructing by the angul… [WIP] fix(module:modal): close modal itself before destructing by the angul… Jul 1, 2018
@wilsoncook
Copy link
Member Author

Needs to pass through the testing.

@wilsoncook wilsoncook force-pushed the fix_modal_scrollbar_when_destroyed branch from a963e58 to 0036917 Compare August 30, 2018 12:40
@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #1769 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
+ Coverage   96.01%   96.02%   +<.01%     
==========================================
  Files         470      470              
  Lines       11424    11433       +9     
  Branches     1515     1516       +1     
==========================================
+ Hits        10969    10978       +9     
  Misses        131      131              
  Partials      324      324
Impacted Files Coverage Δ
components/modal/nz-modal-control.service.ts 100% <100%> (ø) ⬆️
components/modal/nz-modal.component.ts 96.2% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e1f5f...ba98429. Read the comment docs.

@wilsoncook wilsoncook changed the title [WIP] fix(module:modal): close modal itself before destructing by the angul… fix(module:modal): close modal itself before destructing by the angul… Aug 30, 2018
@wilsoncook wilsoncook requested a review from vthinkxie August 30, 2018 13:46
@wzhudev wzhudev merged commit 075c7a4 into NG-ZORRO:master Aug 31, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal & location back bug
2 participants