Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip,popconfirm,popover): not create element when use directive #1968

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Aug 10, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1967

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 11, 2018

Codecov Report

Merging #1968 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   96.03%   96.03%   +<.01%     
==========================================
  Files         470      470              
  Lines       11417    11421       +4     
  Branches     1513     1513              
==========================================
+ Hits        10964    10968       +4     
  Misses        130      130              
  Partials      323      323
Impacted Files Coverage Δ
components/tooltip/nz-tooltip.directive.ts 96.22% <100%> (+0.07%) ⬆️
components/popconfirm/nz-popconfirm.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a84a9...67bb46f. Read the comment docs.

@hsuanxyz hsuanxyz requested a review from vthinkxie August 19, 2018 08:46
@hsuanxyz hsuanxyz merged commit fa40145 into NG-ZORRO:master Aug 19, 2018
@hsuanxyz hsuanxyz deleted the tooltip/fix-tag branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants