Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support service to create drawer #1981

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1937

What is the new behavior?

support service

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1981 into master will increase coverage by 0.01%.
The diff coverage is 98.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage      96%   96.02%   +0.01%     
==========================================
  Files         479      481       +2     
  Lines       11697    11817     +120     
  Branches     1564     1575      +11     
==========================================
+ Hits        11230    11347     +117     
  Misses        132      132              
- Partials      335      338       +3
Impacted Files Coverage Δ
...ents/core/services/nz-measure-scrollbar.service.ts 81.81% <ø> (ø) ⬆️
...ts/core/overlay/scroll/nz-block-scroll-strategy.ts 100% <100%> (ø) ⬆️
components/drawer/nz-drawer-ref.ts 100% <100%> (ø)
components/drawer/nz-drawer.service.ts 100% <100%> (ø)
components/drawer/nz-drawer.module.ts 100% <100%> (ø) ⬆️
.../core/overlay/scroll/nz-scroll-strategy-options.ts 100% <100%> (ø) ⬆️
components/drawer/nz-drawer.component.ts 97.45% <97.91%> (+0.01%) ⬆️
components/table/nz-table.component.ts 95% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c5210...ec98543. Read the comment docs.

@xingkoo
Copy link

xingkoo commented Aug 16, 2018

Thanks, expectations

@hsuanxyz hsuanxyz force-pushed the drawer/feat-service branch from 6af4148 to a7d7205 Compare August 19, 2018 11:09
@hsuanxyz hsuanxyz changed the title WIP(module:drawer): support service to create drawer feat(module:drawer): support service to create drawer Aug 19, 2018
@hsuanxyz hsuanxyz requested a review from vthinkxie August 19, 2018 11:32
}
}

@Injectable()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provideIn:root

@xingkoo
Copy link

xingkoo commented Sep 17, 2018

@hsuanxyz Conflicting files. i hope it can be used as fast. thanks very much

@hsuanxyz hsuanxyz force-pushed the drawer/feat-service branch 4 times, most recently from 132a615 to b30da11 Compare September 21, 2018 09:51
@vthinkxie vthinkxie merged commit a232d59 into NG-ZORRO:master Sep 21, 2018
@hsuanxyz hsuanxyz deleted the drawer/feat-service branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants