Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): take minimum of page range and total #2046

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 27, 2018

close #2036

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2036

What is the new behavior?

When the last page shows up, range[1] would be nzTotal.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #2046 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage   96.01%   96.01%   +<.01%     
==========================================
  Files         470      470              
  Lines       11424    11426       +2     
  Branches     1515     1515              
==========================================
+ Hits        10969    10971       +2     
  Misses        131      131              
  Partials      324      324
Impacted Files Coverage Δ
components/pagination/nz-pagination.component.ts 99.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e1f5f...85dd4f1. Read the comment docs.

@wzhudev wzhudev requested a review from hsuanxyz August 27, 2018 08:06
@wzhudev wzhudev merged commit 30bccd1 into NG-ZORRO:master Aug 31, 2018
@wzhudev wzhudev deleted the table-page-range branch September 11, 2018 09:44
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table: range[1] is larger than total when the last page's size is smaller than nzPageSize
2 participants