Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): hide next and prev buttons #2239

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 3, 2018

close #1964

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The class ant-tabs-bar which defined in [nz-tabs-nav] host is rendered after ngAfterContentInit ( this conclusion is only according to my debugging, is there any angular mechanism to point this ? ).

'[class.ant-tabs-bar]': 'true'

showPaginationControls will get wrong result because the tabs-nav is not vertical:

84ef4b05161c246541289bc1ee0953b4

so define the class in div will fix this issue.

@wenqi73 wenqi73 changed the title fix(component:tabs): hide next and prev buttons when nzTabPosition is… fix(module:tabs): hide next and prev buttons Oct 3, 2018
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2239 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2239      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +<.01%     
==========================================
  Files         482      482              
  Lines       11965    11965              
  Branches     1594     1594              
==========================================
+ Hits        11482    11483       +1     
  Misses        134      134              
+ Partials      349      348       -1
Impacted Files Coverage Δ
components/tabs/nz-tabs-nav.component.ts 91.82% <ø> (ø) ⬆️
components/tabs/nz-tabset.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d123eb...e35836c. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie October 4, 2018 07:47
@vthinkxie vthinkxie merged commit 3bb8be5 into NG-ZORRO:master Oct 11, 2018
@wenqi73 wenqi73 deleted the fix-tabs branch October 11, 2018 09:27
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this pull request Oct 15, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Bug: The next and prev buttons display abnormal
2 participants