Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): fix icon classname writeback #2259

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 10, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev wzhudev requested a review from vthinkxie October 10, 2018 11:25
@wzhudev wzhudev force-pushed the fix-icon-classname branch from 6ac79bf to da01f84 Compare October 10, 2018 11:25
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2259 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2259      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         485      485              
  Lines       12146    12142       -4     
  Branches     1629     1628       -1     
==========================================
- Hits        11634    11630       -4     
  Misses        152      152              
  Partials      360      360
Impacted Files Coverage Δ
components/icon/nz-icon.directive.ts 81.33% <80%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee95fa3...da01f84. Read the comment docs.

@vthinkxie vthinkxie merged commit c6337c2 into NG-ZORRO:master Oct 10, 2018
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this pull request Oct 15, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants