Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): fix icons problems #2325

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 22, 2018

  • update dependency to reduce icons requests
  • fix class name not changes when type changes
  • add svg data-icon

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2325 into master will decrease coverage by 0.02%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2325      +/-   ##
==========================================
- Coverage   95.88%   95.85%   -0.03%     
==========================================
  Files         485      485              
  Lines       12195    12213      +18     
  Branches     1642     1646       +4     
==========================================
+ Hits        11693    11707      +14     
- Misses        146      148       +2     
- Partials      356      358       +2
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 96.75% <100%> (ø) ⬆️
components/layout/nz-layout.module.ts 100% <100%> (ø) ⬆️
components/icon/nz-icon.service.ts 97.14% <100%> (-0.08%) ⬇️
components/icon/nz-icon.directive.ts 94.25% <92.59%> (-1.47%) ⬇️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️
components/tabs/nz-tabset.component.ts 96.58% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1dafc...c73ed5b. Read the comment docs.

@wzhudev wzhudev force-pushed the fix-icon-components branch 2 times, most recently from 196095d to d286c55 Compare October 23, 2018 05:34
* update dependency to reduce icons requests
* fix class name not changes when `type` changes
* add svg data-icon

fix(module:form): fix icon style
@wzhudev wzhudev force-pushed the fix-icon-components branch from d286c55 to 9fd9e97 Compare October 23, 2018 06:12
@vthinkxie vthinkxie merged commit 8a0d412 into NG-ZORRO:master Oct 23, 2018
@wzhudev wzhudev deleted the fix-icon-components branch October 25, 2018 04:17
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants