Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:collapse): add extra field #2923

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 19, 2019

close #1911

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Ref ant design: ant-design/ant-design#14820.

@wzhudev wzhudev marked this pull request as ready for review February 19, 2019 04:10
@wzhudev wzhudev requested a review from vthinkxie February 19, 2019 04:10
@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 58927d9

https://deploy-preview-2923--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #2923 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
+ Coverage   97.36%   97.36%   +<.01%     
==========================================
  Files         524      524              
  Lines       11041    11042       +1     
  Branches      782      782              
==========================================
+ Hits        10750    10751       +1     
  Misses        190      190              
  Partials      101      101
Impacted Files Coverage Δ
components/collapse/nz-collapse-panel.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab62b40...f6825c9. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f6825c9

https://deploy-preview-2923--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit dd0cec2 into NG-ZORRO:master Feb 19, 2019
@wzhudev wzhudev deleted the collapse-extra branch February 22, 2019 02:29
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:collapse): add extra field
close NG-ZORRO#1911

* test: add test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:collapse): add extra field
close NG-ZORRO#1911

* test: add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse: add extra to nz-collapse-panel
2 participants