-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module: tree): fix default keys bug with setTimeOut #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for ng-zorro-master ready! Built with commit f302057 |
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
==========================================
- Coverage 97.35% 97.32% -0.04%
==========================================
Files 550 550
Lines 11454 11506 +52
Branches 815 816 +1
==========================================
+ Hits 11151 11198 +47
- Misses 190 198 +8
+ Partials 113 110 -3
Continue to review full report at Codecov.
|
simplejason
changed the title
fix(module: tree): fix default keys bug with setTimeOut
[WIP] fix(module: tree): fix default keys bug with setTimeOut
Mar 2, 2019
simplejason
force-pushed
the
fix-tree-bug
branch
2 times, most recently
from
March 2, 2019 16:39
b0aee9b
to
21bfa3c
Compare
simplejason
changed the title
[WIP] fix(module: tree): fix default keys bug with setTimeOut
fix(module: tree): fix default keys bug with setTimeOut
Mar 2, 2019
simplejason
force-pushed
the
fix-tree-bug
branch
from
March 2, 2019 17:02
21bfa3c
to
20907a1
Compare
hsuanxyz
reviewed
Mar 4, 2019
hsuanxyz
requested changes
Mar 4, 2019
hsuanxyz
requested changes
Mar 4, 2019
simplejason
force-pushed
the
fix-tree-bug
branch
from
March 4, 2019 04:04
3029b5f
to
c749bb6
Compare
hsuanxyz
approved these changes
Mar 4, 2019
close NG-ZORRO#3001 fix(module: tree): remove unused code fix(module: tree): fix tree spec test fix(module: tree): fix tree demo fix(module: tree): fix tree drag event and remove unsave code fix(module: tree-select): remove code comments fix(module: tree): fix demo
simplejason
force-pushed
the
fix-tree-bug
branch
from
March 4, 2019 07:33
c749bb6
to
f302057
Compare
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
close NG-ZORRO#3001 fix(module: tree): remove unused code fix(module: tree): fix tree spec test fix(module: tree): fix tree demo fix(module: tree): fix tree drag event and remove unsave code fix(module: tree-select): remove code comments fix(module: tree): fix demo
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
close NG-ZORRO#3001 fix(module: tree): remove unused code fix(module: tree): fix tree spec test fix(module: tree): fix tree demo fix(module: tree): fix tree drag event and remove unsave code fix(module: tree-select): remove code comments fix(module: tree): fix demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3001
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3001
What is the new behavior?
Does this PR introduce a breaking change?
Other information