Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix th check not trigger bug #3064

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix(module:table): fix th check not trigger bug #3064

merged 1 commit into from
Mar 11, 2019

Conversation

vthinkxie
Copy link
Member

close #3028 close #3056 close #3058

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3064 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
- Coverage   97.32%   97.32%   -0.01%     
==========================================
  Files         549      549              
  Lines       11490    11487       -3     
  Branches      815      815              
==========================================
- Hits        11183    11180       -3     
  Misses        197      197              
  Partials      110      110
Impacted Files Coverage Δ
components/table/nz-th.component.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa16de...9cd87e1. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9cd87e1

https://deploy-preview-3064--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit dbc33ae into NG-ZORRO:master Mar 11, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-table filter not change after click the checkbox custom filter in table check checkbox not trigger change
2 participants