Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:dropdown): fix the style of CDK conflicts #3133

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3075

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0d2f623

https://deploy-preview-3133--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #3133 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3133      +/-   ##
==========================================
+ Coverage   97.34%   97.34%   +<.01%     
==========================================
  Files         552      552              
  Lines       11587    11588       +1     
  Branches      827      827              
==========================================
+ Hits        11279    11280       +1     
  Misses        195      195              
  Partials      113      113
Impacted Files Coverage Δ
components/dropdown/nz-dropdown.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...0d2f623. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit a9cd84d into NG-ZORRO:master Mar 27, 2019
@hsuanxyz hsuanxyz deleted the fix/dropdown-cdk-styles branch April 22, 2019 02:39
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants