fix(module:steps):updateChildrenSteps bug
#3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 14847d3 |
Codecov Report
@@ Coverage Diff @@
## master #3194 +/- ##
=========================================
Coverage ? 97.38%
=========================================
Files ? 559
Lines ? 11642
Branches ? 836
=========================================
Hits ? 11338
Misses ? 193
Partials ? 111
Continue to review full report at Codecov.
|
|
@giscafer Can you add a test for it? Sorry for the misleading! |
|
An error occurred while I was executing the test @wendzhue E:\ng-zorro-antd>npm run test
> ng-zorro-antd@0.0.0-NOT-USED test E:\ng-zorro-antd
> ng test --watch=false --code-coverage
10% building 4/5 modules 1 active ...orro-antd\components sync /\.spec\.ts$/04 04 2019 14:27:07.523:INFO [karma]: Karma v3.0.0 server started at http://0.0.0.0:9876/
04 04 2019 14:27:07.531:INFO [launcher]: Launching browser Chrome with unlimited concurrency
04 04 2019 14:27:07.546:INFO [launcher]: Starting browser Chrome
ERROR in components/menu/nz-menu.service.ts(13,3): error TS2742: The inferred type of 'check$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/menu/nz-submenu.component.ts(80,3): error TS2742: The inferred type of 'overlayPositions' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/@angular/cdk/overlay'. This is likely not portable. A type annotation is necessary.
components/menu/nz-submenu.service.ts(11,3): error TS2742: The inferred type of 'mode$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/menu/nz-submenu.service.ts(28,3): error TS2742: The inferred type of 'menuOpen$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type
annotation is necessary.
components/select/nz-select.service.ts(45,3): error TS2742: The inferred type of 'open$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/select/nz-select.service.ts(52,3): error TS2742: The inferred type of 'listOfSelectedValue$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/select/nz-select.service.ts(53,3): error TS2742: The inferred type of 'modelChange$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/select/nz-select.service.ts(68,3): error TS2742: The inferred type of 'searchValue$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/select/nz-select.service.ts(96,3): error TS2742: The inferred type of 'valueOrOption$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.
components/select/nz-select.service.ts(114,3): error TS2742: The inferred type of 'check$' cannot be named without a reference to 'E:/1zitonFE/ng-zorro-antd/node_modules/rxjs'. This is likely not portable. A type annotation is necessary.environment _ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 7.3.8
Node: 10.4.1
OS: win32 x64
Angular: 7.2.12
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker
Package Version
------------------------------------------------------------
@angular-devkit/architect 0.13.8
@angular-devkit/build-angular 0.13.8
@angular-devkit/build-ng-packagr 0.13.8
@angular-devkit/build-optimizer 0.13.8
@angular-devkit/build-webpack 0.13.8
@angular-devkit/core 7.2.4
@angular-devkit/schematics 7.2.4
@angular/cdk 7.3.6
@angular/cli 7.3.8
@angular/pwa 0.12.4
@ngtools/json-schema 1.1.0
@ngtools/webpack 7.3.8
@schematics/angular 7.2.4
@schematics/update 0.13.8
ng-packagr 4.7.1
rxjs 6.3.3
typescript 3.2.2
webpack 4.29.0 |
|
Just downgrade your typescript to 3.1.6. It's a bug of typescript. For more details you can check this: #2798 (comment). |
|
@wendzhue The test case has been modified. Is there any problem? The existing project needs to fix this bug. |
|
@giscafer Would be released in the next version. |
hsuanxyz
changed the title
updateChildrenSteps bug
andrew-yangy
pushed a commit
to andrew-yangy/ng-zorro-antd
that referenced
this pull request
Jun 20, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3193
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information