feat(module:modal): loading state (confirmLoading) of default footer in modal opened by nzModalService #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alche1224
changed the title
vthinkxie
requested changes
Sep 22, 2017
| props[ 'onCancel' ] = this._getConfirmCb(props[ 'nzOnCancel' ]); | ||
| // 在service模式下，不需要nzOnOk，防止触发this.nzOnOk.emit(e); | ||
| delete props[ 'nzOnOk' ]; | ||
| delete props[ 'nzOnCancel' ]; | ||
| return props; | ||
| } | ||
|
|
||
| _getConfirmCb(fn?: Function): Function { | ||
| return (_close) => { | ||
| _getConfirmCb(fn?: Function, isShowConfrimLoading: boolean = false): Function { |
There was a problem hiding this comment.
isShowConfrimLoading-> isShowConfirmLoading
There was a problem hiding this comment.
Oh! What a stupid mistake!
| props[ 'onCancel' ] = this._getConfirmCb(props[ 'nzOnCancel' ]); | ||
| // 在service模式下，不需要nzOnOk，防止触发this.nzOnOk.emit(e); | ||
| delete props[ 'nzOnOk' ]; | ||
| delete props[ 'nzOnCancel' ]; | ||
| return props; | ||
| } | ||
|
|
||
| _getConfirmCb(fn?: Function): Function { | ||
| return (_close) => { | ||
| _getConfirmCb(fn?: Function, isShowConfrimLoading: boolean = false): Function { |
There was a problem hiding this comment.
Hi, @AlcheXie thanks for your pr.
It would be better submit an issue before pr any new feat, and doc needs updated when new feat added.
There was a problem hiding this comment.
Ok, I see. I will update these changes later.
alche1224
force-pushed
the
fix-modal
branch
from
8ad15d0 to
5fecd56
Compare
alche1224
force-pushed
the
fix-modal
branch
from
5fecd56 to
dd5f600
Compare
vthinkxie
approved these changes
Sep 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#365
What is the new behavior?
Does this PR introduce a breaking change?
Other information