Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:grid): Make all properties in EmbeddedProperty optional #3473

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix(module:grid): Make all properties in EmbeddedProperty optional #3473

merged 1 commit into from
Jun 25, 2019

Conversation

qqabcv520
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

TIM图片20190522102031

All properties in EmbeddedProperty are not optional.

What is the new behavior?

All properties in EmbeddedProperty are optional.

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

@netlify
Copy link

netlify bot commented May 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9b65255

https://deploy-preview-3473--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #3473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3473   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files         609     609           
  Lines       13250   13250           
  Branches     1810    1810           
======================================
  Hits        12668   12668           
  Misses        197     197           
  Partials      385     385
Impacted Files Coverage Δ
components/grid/nz-col.directive.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e04f4b...9b65255. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 107e731 into NG-ZORRO:master Jun 25, 2019
@pr-triage pr-triage bot added the PR: merged label Jun 25, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants