Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support global config #3598

Closed
45 of 64 tasks
wzhudev opened this issue Jun 18, 2019 · 1 comment
Closed
45 of 64 tasks

feat: support global config #3598

wzhudev opened this issue Jun 18, 2019 · 1 comment
Assignees
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes 🌈 Feature Request ⛳ Roadmap help wanted

Comments

@wzhudev
Copy link
Member

wzhudev commented Jun 18, 2019

feat: support global config 支持全局配置项

给小伙伴们的开发指南

如果你的组件需要支持全局配置项,你应该:

  • 确保你的组件已依赖到 NzConfigService
  • NzConfig 接口增加你组件所支持的全局配置项
  • 静态配置项:至少要支持静态配置,将全局配置项和和原来老的配置项(如果有)合并,对于指令和组件来说,你可以使用 PropWithConfig 装饰器。
  • 动态配置项:可以选择支持动态配置,监听 NzConfigServiceconfigUpdated$ 事件,并在你的组件被更新时触发重渲染等等
  • 修改组件文档并(在 9.0.0 中)弃用老的配置项,注意给出弃用警告

请按这个清单处理你负责的组件。

#3613

List

一些组件可能无需支持,请用 🤔 标识

Some components that don't need global config would be marked with 🤔.

@wzhudev
Copy link
Member Author

wzhudev commented Sep 9, 2019

Closed by #3613

@wzhudev wzhudev closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes 🌈 Feature Request ⛳ Roadmap help wanted
Projects
None yet
Development

No branches or pull requests

6 participants