-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:tabs): support link router #3718
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #3718 +/- ##
=========================================
- Coverage 95.4% 95.4% -0.01%
=========================================
Files 711 712 +1
Lines 14593 14632 +39
Branches 1924 1929 +5
=========================================
+ Hits 13923 13959 +36
- Misses 243 244 +1
- Partials 427 429 +2
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 2a5969f |
@wendzhue Thank you for this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tryActivateLink should be removed, routerChange should base on a link href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information