Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): missing nzUse12Hours binding #3781

Merged
merged 1 commit into from
Jul 15, 2019
Merged

fix(module:date-picker): missing nzUse12Hours binding #3781

merged 1 commit into from
Jul 15, 2019

Conversation

elishnevsky
Copy link
Contributor

@elishnevsky elishnevsky commented Jul 12, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Binding nzShowTime of a date-picker to an object that has nzUse12Hours set to true has no effect on a time picker, it still uses 24 hour picker.

Issue Number: N/A

What is the new behavior?

Binding the nzShowTime input of a date-picker to an object that has nzUse12Hours set to true modifies the time picker to use 12 hours format picker as expected.

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@netlify
Copy link

netlify bot commented Jul 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 35e94f0

https://deploy-preview-3781--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #3781 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3781      +/-   ##
==========================================
- Coverage   95.39%   95.39%   -0.01%     
==========================================
  Files         712      712              
  Lines       14542    14542              
  Branches     1913     1913              
==========================================
- Hits        13873    13872       -1     
  Misses        243      243              
- Partials      426      427       +1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 96.57% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979807d...35e94f0. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vthinkxie vthinkxie merged commit feae069 into NG-ZORRO:master Jul 15, 2019
lppedd pushed a commit to lppedd/ng-zorro-antd that referenced this pull request Jul 15, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants