fix(module:message): fix lazy load problem #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 22e4073 |
|
Deploy preview for ng-zorro-master ready! Built with commit bb69d20 |
Codecov Report
@@ Coverage Diff @@
## master #3797 +/- ##
==========================================
- Coverage 95.37% 95.36% -0.01%
==========================================
Files 706 709 +3
Lines 14515 14574 +59
Branches 1915 1924 +9
==========================================
+ Hits 13843 13898 +55
- Misses 244 246 +2
- Partials 428 430 +2
Continue to review full report at Codecov.
|
wzhudev
reviewed
Jul 16, 2019
| this._container.setConfig(config); | ||
| } | ||
|
|
||
| protected _generateMessageId(): string { |
wzhudev
reviewed
Jul 16, 2019
| return resultMessage; | ||
| } | ||
|
|
||
| config(config: MessageConfig): void { |
There was a problem hiding this comment.
如果用户在两个 FeatureModule 里都引入了 NzMessageModule，那么在其中一个 module 调用此方法时，对其他 module 里的 message container 应该不会生效，因为每个 module 都会创建自己的 service 实例。
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* fix(module:message): fix lazy load problem close NG-ZORRO#3794 * test(module:message): fix test * fix(module:message): fix module
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* fix(module:message): fix lazy load problem close NG-ZORRO#3794 * test(module:message): fix test * fix(module:message): fix module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3794
What is the new behavior?
Does this PR introduce a breaking change?
Other information