Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix table scrollbar bug #3801

Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix(module:table): fix table scrollbar bug #3801

merged 1 commit into from
Jul 16, 2019

Conversation

vthinkxie
Copy link
Member

close #3796

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jul 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 03069f2

https://deploy-preview-3801--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #3801 into master will decrease coverage by 0.02%.
The diff coverage is 74.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3801      +/-   ##
==========================================
- Coverage   95.37%   95.34%   -0.03%     
==========================================
  Files         706      705       -1     
  Lines       14515    14516       +1     
  Branches     1915     1920       +5     
==========================================
- Hits        13843    13841       -2     
- Misses        244      245       +1     
- Partials      428      430       +2
Impacted Files Coverage Δ
components/core/services/public-api.ts 100% <ø> (ø) ⬆️
components/table/nz-table.module.ts 100% <100%> (ø) ⬆️
components/core/util/public-api.ts 100% <100%> (ø) ⬆️
components/core/util/measure-scrollbar.ts 72% <72%> (ø)
components/table/nz-table.component.ts 93.03% <75%> (-0.56%) ⬇️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feae069...03069f2. Read the comment docs.

@vthinkxie vthinkxie merged commit 7e00e52 into NG-ZORRO:master Jul 16, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Grouping table head not respecting nzWidthConfig
1 participant