Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:cascader): fix column is not dropped in hover mode #3916

Merged
merged 2 commits into from
Aug 26, 2019
Merged

fix(module:cascader): fix column is not dropped in hover mode #3916

merged 2 commits into from
Aug 26, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 2, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • I get the components to support i18n.
  • I deprecated one API as well. nzSelect. It does almost the same thing nzSelectionChange but it's less powerful because instead of emitting all selected options, it only emits the newly selected option.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev changed the title fix: fix column is not dropped in hover mode fix(module:cascader): fix column is not dropped in hover mode Aug 2, 2019
@netlify
Copy link

netlify bot commented Aug 2, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit e422b9d

https://deploy-preview-3916--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 2, 2019 •
edited
Loading

Codecov Report

Merging #3916 into master will increase coverage by 0.01%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
+ Coverage   92.42%   92.44%   +0.01%     
==========================================
  Files         506      506              
  Lines       10749    10756       +7     
  Branches     1942     1940       -2     
==========================================
+ Hits         9935     9943       +8     
+ Misses        400      399       -1     
  Partials      414      414
Impacted Files Coverage Δ
components/cascader/nz-cascader.service.ts 96.7% <100%> (+0.05%) ⬆️
components/cascader/nz-cascader.component.ts 95.91% <93.75%> (+0.06%) ⬆️
components/core/util/text-measure.ts 85.71% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5f452...e422b9d. Read the comment docs.

@wzhudev
Copy link
Member Author

wzhudev commented Aug 6, 2019

close #3914

@wzhudev wzhudev requested a review from vthinkxie August 13, 2019 02:19
@wzhudev wzhudev force-pushed the cascader-hide-leaf branch 2 times, most recently from ad0a64d to 23f00e1 Compare August 13, 2019 07:27
@wzhudev wzhudev force-pushed the cascader-hide-leaf branch from 23f00e1 to a7035f1 Compare August 13, 2019 09:39
@wzhudev wzhudev requested a review from hsuanxyz August 13, 2019 11:07
vthinkxie
vthinkxie requested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugs not fixed

@wzhudev
Copy link
Member Author

wzhudev commented Aug 13, 2019

bugs not fixed

😢

@wzhudev wzhudev force-pushed the cascader-hide-leaf branch from a7035f1 to 17f34fc Compare August 13, 2019 12:52
@wzhudev wzhudev force-pushed the cascader-hide-leaf branch 2 times, most recently from c3062e6 to 534b6ad Compare August 14, 2019 12:15
@wzhudev wzhudev force-pushed the cascader-hide-leaf branch from 534b6ad to e422b9d Compare August 23, 2019 05:45
vthinkxie
vthinkxie approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 906849b into NG-ZORRO:master Aug 26, 2019
@wzhudev wzhudev deleted the cascader-hide-leaf branch August 27, 2019 02:01
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:cascader): fix column is not dropped in hover mode (NG-ZOR…
e7036f9 
…RO#3916)

* fix: fix column is not dropped in hover mode

* fix: improve code coverage
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@simplejason
fix(module:cascader): fix column is not dropped in hover mode (NG-ZOR…
918542f 
…RO#3916)

* fix: fix column is not dropped in hover mode

* fix: improve code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzhudev @vthinkxie @simplejason