Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:description): fix colspan calcuation in horizontal bordered #4014

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 14, 2019

close #4013

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 14, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 930efc9

https://deploy-preview-4014--ng-zorro-master.netlify.com

@wzhudev wzhudev force-pushed the descriptions-colspan branch from 6d9d490 to 930efc9 Compare August 14, 2019 12:15
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #4014 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4014      +/-   ##
==========================================
+ Coverage   92.41%   92.45%   +0.03%     
==========================================
  Files         506      506              
  Lines       10749    10749              
  Branches     1942     1942              
==========================================
+ Hits         9934     9938       +4     
+ Misses        400      398       -2     
+ Partials      415      413       -2
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️
components/core/util/text-measure.ts 87.61% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272e32a...930efc9. Read the comment docs.

@simplejason simplejason self-requested a review August 26, 2019 02:41
@simplejason simplejason merged commit 345712f into NG-ZORRO:master Aug 26, 2019
@wzhudev wzhudev deleted the descriptions-colspan branch August 27, 2019 02:03
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions 组件 nzSpan 在有边框水平方向的情况下和其他情况效果不一致
2 participants