feat(module:affix&anchor&back-top&avatar): add components to library #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipchk
changed the title
wilsoncook
reviewed
Aug 25, 2017
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| this._anchorComp.scrollTo(this); | ||
| return false; |
There was a problem hiding this comment.
Suggest: no need to "return false"
wilsoncook
added a commit
to wilsoncook/ng-zorro-antd
that referenced
this pull request
Aug 26, 2017
wilsoncook
approved these changes
Aug 26, 2017
| setTimeout(() => { | ||
| this.handleScroll(); | ||
| }, 500); | ||
| this.scroll$ = Observable.fromEvent(this.getTarget(), 'scroll') |
There was a problem hiding this comment.
"fromEvent" will not available before you import it, so pls import { fromEvent } from 'rxjs/observables/fromEvent' and then use this way to avoid polluting user's global Observable object: fromEvent(xxx, 'xxx'). Why? see: https://github.com/angular/material2/blob/master/CODING_STANDARDS.md#rxjs
| private registerScrollEvent() { | ||
| this.removeListen(); | ||
| this.handleScroll(); | ||
| this.scroll$ = Observable.fromEvent(this.getTarget(), 'scroll') |
There was a problem hiding this comment.
Should import fromEvent as mentioned above.
| private registerScrollEvent() { | ||
| this.removeListen(); | ||
| this.reCalculate().process(); | ||
| this.scroll$ = Observable.fromEvent(this.getTarget(), 'scroll') |
There was a problem hiding this comment.
Should import fromEvent as mentioned below.
|
|
||
| if (this.getTarget() !== window) { | ||
| // 当 window 滚动位发生变动时，需要重新计算滚动容器 | ||
| this.scrollWinInTarget$ = Observable.fromEvent(window, 'scroll') |
There was a problem hiding this comment.
Should import fromEvent as mentioned below.
|
|
||
| let linkNode = (maxSection.comp.el.nativeElement as HTMLDivElement).querySelector('.ant-anchor-link-title') as HTMLElement; | ||
| this.ball.nativeElement.style.top = `${linkNode.offsetTop + linkNode.clientHeight / 2 - 4.5}px`; | ||
| console.log(linkNode, linkNode.offsetTop + linkNode.clientHeight / 2 - 4.5); |
|
it seems that you are use |
|
@LinboLen Have noticed, but CRLF is default in Windows. Any side effects is good to be heard. |
|
”树“控件计划什么时候引入进来 |
suraciii
pushed a commit
to suraciii/ng-zorro-antd
that referenced
this pull request
Aug 30, 2017
* master: refactor(module:dropdown): improve performance (NG-ZORRO#148) feat(module:tooltip,popconfirm,popover): support OnPush (NG-ZORRO#143) release(0.5.0-rc.3): pre-release 0.5.0-rc.3 (NG-ZORRO#166) fix(module:carousel): fix carousel auto play bug (NG-ZORRO#164) fix(module:input): fix input disabled style bug (NG-ZORRO#160) fix(module:input): fix input disabled style bug (NG-ZORRO#108) fix(module:affix,anchor,back-top): fix and improve rxjs usage (NG-ZORRO#159) feat(module:affix&anchor&back-top&avatar): add components to library (NG-ZORRO#88) fix(module:select): fix select reset bug in form (NG-ZORRO#153) fix(module:pagination) fix pagination double binding (NG-ZORRO#146) fix(module:select): fix option incorrect active status (NG-ZORRO#141) feat(module:root): make nz-root optional (NG-ZORRO#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?