Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we remove or greatly simplify strnum.f? #369

Closed
edwardhartnett opened this issue Mar 11, 2023 · 2 comments · Fixed by #406
Closed

can we remove or greatly simplify strnum.f? #369

edwardhartnett opened this issue Mar 11, 2023 · 2 comments · Fixed by #406
Labels
question Further information is requested

Comments

@edwardhartnett
Copy link
Contributor

We have strnum.f. It says:

C> This subroutine decodes an integer from a character string.  The
C> string should contain only digits and (optional) trailing blanks.
C> It should not contain any sign ('+' or '-') character nor any
C> leading blanks nor embedded blanks.

Can this not be done with standard fortran in a single command? Why do we have a subprogram for this?

@jbathegit
Copy link
Collaborator

There's no single standard Fortran command that I've ever seen which does this. But in #406 I was able to greatly simplify and modernize both strnum and strsuc (and convert them to F90), and I also removed the duplicated functionality in valx.

@edwardhartnett edwardhartnett changed the title can we remove strnum.f? can we remove or greatly simplify strnum.f? Mar 22, 2023
@edwardhartnett
Copy link
Contributor Author

I believe there is still more to discuss here, so I will reopen this issue. But before discussing it, let's resolve #407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants