Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy build instructions and files from tests directory #37

Closed
edwardhartnett opened this issue Dec 8, 2021 · 3 comments · Fixed by #44
Closed

Remove legacy build instructions and files from tests directory #37

edwardhartnett opened this issue Dec 8, 2021 · 3 comments · Fixed by #44
Assignees
Labels
test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

Seems like we have one unit test, and it is being run by CMake and in the CI.

@BoiVuong-NOAA and @kgerheiser are we running the full set of tests from CMake?

If so, let's remove all the files we don't need for that...

@edwardhartnett edwardhartnett added the test Testing is important! label Dec 8, 2021
@edwardhartnett edwardhartnett self-assigned this Dec 8, 2021
@BoiVuong-NOAA
Copy link
Contributor

I do not know about tests from CMake. So, I will not continue to work on test_params_grib2_tbl_new.f90.

@edwardhartnett
Copy link
Contributor Author

Are you going to add test code for your open PR?

Are there tests in the tests directory that are not being run by CMake?

What is test_params_grib2_tbl_new.f90?

@BoiVuong-NOAA
Copy link
Contributor

I can modify the test code to add some new fields. I think these tests run by CMake. But, We only need test_params_grib2_tbl_new.f90.
The test_params_grib2_tbl_new.f90 uses to test new fields that add in the params_grib2_tbl_new file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing is important!
Projects
None yet
2 participants