Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code Review Checklist #33

Open
oelbert opened this issue Oct 17, 2023 · 0 comments
Open

Update Code Review Checklist #33

oelbert opened this issue Oct 17, 2023 · 0 comments

Comments

@oelbert
Copy link
Contributor

oelbert commented Oct 17, 2023

Pace PRs still imply you should check your code against the old DSL team's checklist, which is not accessible to anyone outside AI2. If we want to still use this as a guide for Pace code it should be somewhere accessible, maybe in the repo itself? We can (should) also edit it so it's in line with our current standards (and omits the OOP refactor section), or we should just remove that bullet point from the PR text completely if we don't want to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant