Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to init model on not implemented configurations #46

Open
FlorianDeconinck opened this issue Dec 19, 2023 · 2 comments
Open

Fail to init model on not implemented configurations #46

FlorianDeconinck opened this issue Dec 19, 2023 · 2 comments

Comments

@FlorianDeconinck
Copy link
Collaborator

FlorianDeconinck commented Dec 19, 2023

The Pace repository does not carry all the capacity of the FV3 model. Therefore we need to strongly fail when the namelist/configuration required is not going to work or work poorly.

A first implementation is to use raise NotImplementedError in the __init__ function of the modules. DO NOT RAISE AT RUNTIME, keep guard at initialization or fear my wrath.

Current non-exhaustive list:

  • do_sat_adjust
  • kord is 9 or 10
  • nwat is 6
  • non hydrostatic

List to be double checked and completed

@FlorianDeconinck
Copy link
Collaborator Author

PR incoming with some checks

@bensonr
Copy link
Contributor

bensonr commented Dec 20, 2023

There are multiple microphysical schemes with the same number of water species, but the makeup of species is different. We need to come up with a better way than using nwat to determine how the water species break down for the liquid vs solid when computing the subgrid scale mixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants