Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important: Stop committing until restructuring is done #73

Closed
CunliangGeng opened this issue Jun 30, 2022 · 8 comments
Closed

Important: Stop committing until restructuring is done #73

CunliangGeng opened this issue Jun 30, 2022 · 8 comments

Comments

@CunliangGeng
Copy link
Member

Hi all @andrewramsay @justinjjvanderhooft @sdrogers @gcroci2 @louwenjjr

I'm going to restructure this repo and there will be a broken change on the structure and files of this repo (#71 ).

Before I do that, could you please check the following in this week?

  • commit all your work and pull request to master branch
  • then stop working on this repo until the structuring is done (you'll receive a notification)

If you have no commits to push, it's great!
🟢 Please leave me a pass comment, I could start structuring then.

Thank you!

@CunliangGeng CunliangGeng added this to the python-package milestone Jun 30, 2022
@andrewramsay
Copy link
Contributor

I'm not working on anything at the moment and didn't have any plans to do anything in the near future either, so no problem from my side.

@justinjjvanderhooft
Copy link

I have nothing ongoing! FYI: reviewers of NPClassScore may visit the GitHub to check the code or try it on example data.

@andrewramsay
Copy link
Contributor

FYI: reviewers of NPClassScore may visit the GitHub to check the code or try it on example data.

Worth adding a temporary note to the README explaining that restructuring is ongoing and linking to the current latest master commit? That way they can easily retrieve a working version if they want to run anything.

@justinjjvanderhooft
Copy link

good suggestion @andrewramsay - @CunliangGeng could you do that? Thx!

@justinjjvanderhooft
Copy link

Also, I don't think Simon and Joris have ongoing commits....

@CunliangGeng
Copy link
Member Author

Thank you all!

@justinjjvanderhooft no worry about the reviewing, nothing will be changed on the current default branch master. Users can still use it as before even during restructuring.

All restructuring changes will be on a new branch main and it'll be set as the default branch of this repo when we make sure everything goes well.

@CunliangGeng
Copy link
Member Author

CunliangGeng commented Jul 21, 2022

🎉🎉🎉 Restructuring is done!

By restructuring NPLinker codebase with eScience center python template, we split the codebase to two repos, enable packaging, github actions and collaborative dev guide.

With the new restructured codebase, we released

Now you could restart working on NPLinker code. To make collaborative dev easier, have a look at README.dev.md (e.g. this one) and CONTRIBUTING.md (e.g. this one).

@sdrogers
Copy link
Contributor

sdrogers commented Jul 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants