Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on readthedocs.io #74

Closed
andrewramsay opened this issue Jul 4, 2022 · 10 comments
Closed

Documentation on readthedocs.io #74

andrewramsay opened this issue Jul 4, 2022 · 10 comments
Labels
docs documentations
Milestone

Comments

@andrewramsay
Copy link
Contributor

Something I think we have overlooked so far is the auto-generated documentation at https://nplinker.readthedocs.io/en/latest/.

It's slightly broken at the moment because it's missing the NPLinker class documentation but it's set up to automatically rebuild the docs every time a commit is made (through a webhook), I think it'd be useful to keep it around as up-to-date API information for anyone not using the webapp.

I used my personal readthedocs account for this but it looks like I can add other readthedocs accounts as maintainers, so that could be a simple way to transfer ownership to an eScience Center account.

The missing NPLinker class documentation can easily be restored with a tweak to the Sphinx config file but I'll wait until after the refactoring is complete to commit that.

@justinjjvanderhooft
Copy link

Thanks for the heads up @andrewramsay - @CunliangGeng let's make sure this works again once you finished with the refactoring.... 😊

@CunliangGeng CunliangGeng added the docs documentations label Jul 5, 2022
@CunliangGeng
Copy link
Member

@andrewramsay there seems no way to transfer that, but adding more maintainers. could you please add me as a maintainer? my username is CunliangGeng

@justinjjvanderhooft yep, docs for end users and developers are in the plan.

@CunliangGeng CunliangGeng added this to the Refine Docs milestone Jul 5, 2022
@andrewramsay
Copy link
Contributor Author

I've added you as a maintainer now

@justinjjvanderhooft
Copy link

Thanks @andrewramsay - perhaps handy to add me as well? 😎

@CunliangGeng
Copy link
Member

Yes, thanks, it works.

@andrewramsay
Copy link
Contributor Author

@justinjjvanderhooft sure, can do - do you already have an account there? I couldn't see one matching your GitHub username.

@justinjjvanderhooft
Copy link

@andrewramsay - apologies, now you can find me :-)

@andrewramsay
Copy link
Contributor Author

Great, that should be you added as well now

@justinjjvanderhooft
Copy link

Ty!

@CunliangGeng
Copy link
Member

The issue is solved by #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentations
Projects
None yet
Development

No branches or pull requests

3 participants