Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiBIG v3.x support #94

Closed
andrewramsay opened this issue Jan 5, 2023 · 2 comments
Closed

MiBIG v3.x support #94

andrewramsay opened this issue Jan 5, 2023 · 2 comments

Comments

@andrewramsay
Copy link
Contributor

See this issue.

This helper method can cause problems since the v3.x MiBIG JSON format has apparently changed again vs 2.x and 1.x.

So if someone uses the default version (currently still 1.4) and extra BGCs are retrieved separately using download_mibig_bgc_json, it can result in a mix of 1.4 and 3.x formats in the local mibig_json folder.

That then causes an exception in this method because it currently assumes anything that isn't v1.x format must be v2.x.

If support for the MiBIG 3.x JSON format is added to genomics.py it should allow it to handle a mix of different versions.


It might also be sensible to update the default version from 1.4 to 2.0?

@hechth
Copy link
Collaborator

hechth commented Jan 6, 2023

@CunliangGeng I think this is already handled in the development version?

@CunliangGeng
Copy link
Member

Yep, this issue is already solved in dev version, the default version of mibig has been updated to latest v3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants